Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some nightly build infrastructure cruft #3962

Merged
merged 41 commits into from
Nov 20, 2024
Merged

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented Nov 16, 2024

Overview

Closes #3927
Closes #3643
More generous timeouts/retries may address #3958

Tasks

Preview Give feedback

@zaneselvans zaneselvans added docs Documentation for users and contributors. nightly-builds Anything having to do with nightly builds or continuous deployment. labels Nov 16, 2024
@zaneselvans zaneselvans self-assigned this Nov 16, 2024
@zaneselvans zaneselvans marked this pull request as ready for review November 16, 2024 16:55
@zaneselvans zaneselvans requested a review from jdangerx November 16, 2024 16:55
@zaneselvans zaneselvans marked this pull request as draft November 16, 2024 20:02
@zaneselvans zaneselvans marked this pull request as ready for review November 18, 2024 03:40
@zaneselvans zaneselvans requested review from bendnorman and removed request for jdangerx November 18, 2024 20:24
.github/workflows/build-deploy-pudl.yml Show resolved Hide resolved
.github/workflows/build-deploy-pudl.yml Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/gcp_pudl_etl.sh Outdated Show resolved Hide resolved
@zaneselvans zaneselvans linked an issue Nov 19, 2024 that may be closed by this pull request
Copy link
Member

@bendnorman bendnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small suggestions.

docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/gcp_pudl_etl.sh Show resolved Hide resolved
docker/gcp_pudl_etl.sh Outdated Show resolved Hide resolved
docker/gcp_pudl_etl.sh Outdated Show resolved Hide resolved
docs/dev/nightly_data_builds.rst Outdated Show resolved Hide resolved
docs/dev/nightly_data_builds.rst Outdated Show resolved Hide resolved
docker/gcp_pudl_etl.sh Show resolved Hide resolved
@zaneselvans zaneselvans added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit f3cdf14 Nov 20, 2024
17 checks passed
@zaneselvans zaneselvans deleted the nightly-build-cruft branch November 20, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation for users and contributors. nightly-builds Anything having to do with nightly builds or continuous deployment.
Projects
Archived in project
2 participants