Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FERC714 fast CI asset check #3994

Merged

Conversation

cmgosnell
Copy link
Member

@cmgosnell cmgosnell commented Dec 20, 2024

Overview

Working on #3928

What problem does this address?

fixing asset check found in #3990

What did you change?

only check row nums for years that are in the dataset_settings

Documentation

Make sure to update relevant aspects of the documentation.

Tasks

Preview Give feedback

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

Preview Give feedback

@cmgosnell cmgosnell changed the title only check row nums for years that are in the dataset_settings Fix FERC714 fast CI asset check Dec 20, 2024
Comment on lines 1290 to 1293
logger.info(errors)
logger.warning(errors)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i updated this to a warning bc the dagster message is basically nothing and i was missing the info logs bc they just looked normie

@cmgosnell cmgosnell requested review from jdangerx and removed request for jdangerx December 20, 2024 16:52
Copy link
Member

@jdangerx jdangerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cmgosnell cmgosnell marked this pull request as ready for review December 20, 2024 17:02
@cmgosnell cmgosnell merged commit f590ad7 into 3928-asset-checks-run-again Dec 20, 2024
16 of 17 checks passed
@cmgosnell cmgosnell deleted the ferc714-row-num-asset-check-fix branch December 20, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants