Make the reconstructable job not take any arguments at all. #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-belfer
reviewed
Dec 27, 2024
| @@ -365,6 +365,8 @@ def check_rows(context: AssetCheckExecutionContext) -> AssetCheckResult: | |||
| logger.info("Check VCE RARE hourly table is the expected length") | |||
|
|
|||
| # Define row counts for fast/full etl | |||
| # TODO 2024-12-27: make this check row counts per year instead of having | |||
There was a problem hiding this comment.
Agree, but we'll probably eventually wind up with distribution tests that do want fast vs. full specified and can't be parameterized by year, so the solution will probably come in handy anyways?
e-belfer
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What problem does this address?
... the nightly builds are still broken because the reconstructable job doesn't want any parameters at all.
What did you change?
Moved the parameters to the wrapper function.
Documentation
Make sure to update relevant aspects of the documentation.
Testing
How did you make sure this worked? How can a reviewer verify this?
make pytest-integrationpudl_etl --gcs-cache-path gs://internal-zenodo-cache.catalyst.coop ~/work/pudl/src/pudl/package_data/settings/etl_full.yml- see if it even starts