Add setting to restrict noredirect by ip #826 #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwalkerl
force-pushed
the
restrict-noredirect-ip
branch
from
b977f85
to
908ce39
Compare
brendanheywood
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #826
Adds a new setting that allows admins to restrict the use of ?saml=off and ?noredirect=1 during SAML login to access the backdoor to certain IPs.
For now I've limited this functionality to when dual login is disabled as that's the only time it would be a backdoor.
Users can still technically reach the backdoor when there's errors - I thought about adding a check there as well, but it's a bit different from how I've described this feature.