Rewrite student_search_table query #151
Conversation
Details on internal WR 427905
marxjohnson
force-pushed
the
student-search-query
branch
2 times, most recently
from
2ab6f34 to
bc21fb1
Compare
|
I've done as much as I can to get the CI checks passing. There's mustachelint check that's failing due to multiple partials that use {{uniqid}}, not sure what we can do about that, and a load of phpcpd errors in test files that I don't have time to look at now. The behat test is failing on MOODLE_403_STABLE due to changes in the modal API. See #154. |
The only failures are in unit tests now, and this check is being deprecated in moodle-plugin-ci anyway. https://moodlehq.github.io/moodle-plugin-ci/CHANGELOG.html#unreleased
marxjohnson
force-pushed
the
student-search-query
branch
from
ba5e181 to
39820c1
Compare
|
I managed to fix the remaining mustachelint issue, the duplicate IDs it was complaining about weren't actually used anywhere (they were on the spinners, which are selected by class name in the Javascript). I also disabled the phpcpd check as the remaining failures were only in tests, and it is being removed from moodle-plugin-ci in any case. We're now closer to having all the checks passing, although there's still some work to do in a future PR. |
Rewrite student_search_table query
Rewrite student_search_table query
Details on internal WR 427905