Add violation hash and index #66 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bwalkerl
force-pushed
the
66-add-index
branch
from
fcb28dd to
3faa1e3
Compare
| global $DB; | ||
|
|
||
| // Get a recordset of all the unique violateddirect and blockeddomain pairs. | ||
| $recordset = $DB->get_recordset_sql(" |
There was a problem hiding this comment.
this thing could be pure db side, mysql and postgres both have a sha1 function
split this into a new issue for later: #97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the hash can take a long time on sites with a large amount of data. This shouldn't be a problem for sites properly curating data, but is a realistic possibility for sites that enabled report mode and have done nothing with it to have many millions of rows. As such, it was proposed to try and have this correspond with an upgrade.
To accomplish this the MOODLE_500_STABLE branch was created. It is essentially a placeholder that only contains this update for now, but proper support for Moodle 5.0 will be added at a later time if any changes are needed.