Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2p only conversion #22

Merged
merged 7 commits into from
Jun 11, 2024
Merged

2p only conversion #22

merged 7 commits into from
Jun 11, 2024

Conversation

alessandratrapani
Copy link
Collaborator

@alessandratrapani alessandratrapani commented May 28, 2024

Add all the data streams that are common to #1

  • add TTL signals
  • add wheel signals
  • add visual stimulus
  • add Facemap output (after fixing Build a FacemapConverter #19) --> I will do a follow up PR
  • add Video recording
  • align all interfaces

@alessandratrapani
Copy link
Collaborator Author

stb nwb file here

@weiglszonja
Copy link
Collaborator

The wheel signal looks flat for this short segment, is it ok for the whole recording?

Copy link
Collaborator

@weiglszonja weiglszonja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on the wheel signal, others look good.

@alessandratrapani
Copy link
Collaborator Author

The wheel signal looks flat for this short segment, is it ok for the whole recording?

I don't know what went wrong here, but I re-run it and now it looks like this:
image

@weiglszonja
Copy link
Collaborator

Yeah I'm seeing this in neurosift:
Screenshot 2024-06-11 at 13 34 17

@alessandratrapani
Copy link
Collaborator Author

Yeah I'm seeing this in neurosift: Screenshot 2024-06-11 at 13 34 17

Let me update the file

@alessandratrapani
Copy link
Collaborator Author

update version here

@weiglszonja
Copy link
Collaborator

update version here

Is it showing up differently for you in neurosift?

@alessandratrapani
Copy link
Collaborator Author

update version here

Is it showing up differently for you in neurosift?

I see, it's just a scale thing. The actual signal is probably saturated in the first 100 frames, but then it looks like this:
image

@weiglszonja
Copy link
Collaborator

I see, ok then. there's a conflict now with the converter but otherwise feel free to merge this as well

@alessandratrapani alessandratrapani merged commit 164da05 into main Jun 11, 2024
@alessandratrapani alessandratrapani deleted the 2p_only_conversion branch July 8, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants