Fix duplicated file identifiers from sharing metadata #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, anything else you wanted to include in this PR? |
|
nope but I would like to run it on the other session they shared just to double check, since that one had the spike weirdness (if you're okay with holding off reviewing/merging until next Monday). The first session is now in the embargoed dandiset though |
Co-authored-by: Cody Baker <[email protected]>
CodyCBakerPhD
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main fix is manually generating new uuid before creating second NWBFile. Also added logic so that the auto-detected session start times from the SpikeGLX interface aren't overwritten unnecessarily, and fixed the
neuroconvrequirement after the recent schemas fix.