Nick updates. #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elif "monkey1" in str(data_dir_path): | ||
| metadata["Subject"]["subject_id"] = "Elgar" | ||
| if "monkey0" in str(data_dir): | ||
| metadata["Subject"]["subject_id"] = "P" |
There was a problem hiding this comment.
FYI this will be a value that shows up in the final filename on DANDI - I highly recommend making it the full name or some other easily identifiable/communicable string
|
Looks good except for the reduction of the subject ID - thinking we should merge this first then update @felixp8's other branch with his additional doc improvements? |
|
sorry for lack of clarity, all changes here have been incorporated into my other PR. Didn't notice the change to subject ID though so maybe still good to discuss with Nick here |
|
Regarding subject ID, please ignore that change and use the full names as before, thanks! |
|
going to close this one for now in favor of #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes:
watters_convert_session.pyfor PEP8 compliance and a little logging.from jazayeri_lab_to_nwb.watters import ...with imports leaf files to prevent import errors.some-extra-packagefromwatters_requirements.txt.