Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more friendly error when writing recording with multiple offsets #1111

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

h-mayorquin
Copy link
Collaborator

Related to #1106.

This produces error that look like this which should offer better diagnosis to users on which channels are the source of heterogeneity:

        "Recording extractors with heterogeneous offsets are not supported.",
        "Multiple offsets were found per channel IDs:",
        "  Offset 0: Channel IDs ['a', 'b']",
        "  Offset 1: Channel IDs ['c', 'd']",
        "  Offset 2: Channel IDs ['e']",

@h-mayorquin h-mayorquin marked this pull request as ready for review October 10, 2024 20:40
@h-mayorquin h-mayorquin self-assigned this Oct 10, 2024
Copy link
Contributor

@alessandratrapani alessandratrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-mayorquin h-mayorquin merged commit 165cb31 into main Oct 22, 2024
37 of 39 checks passed
@h-mayorquin h-mayorquin deleted the more_friendly_error_for_multiple_offset branch October 22, 2024 14:12
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.59%. Comparing base (36464df) to head (0a3f749).
Report is 23 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   90.44%   90.59%   +0.15%     
==========================================
  Files         129      129              
  Lines        8055     8187     +132     
==========================================
+ Hits         7285     7417     +132     
  Misses        770      770              
Flag Coverage Δ
unittests 90.59% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/neuroconv/tools/spikeinterface/spikeinterface.py 91.08% <100.00%> (+0.31%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants