Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add always_write_timestamps conversion option to imaging interfaces #1125

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

h-mayorquin
Copy link
Collaborator

This was discussed in the context of the Cai project with @alessandratrapani

Similar to this one for the ecephys side:
#1091

@h-mayorquin h-mayorquin self-assigned this Nov 5, 2024
@h-mayorquin h-mayorquin changed the title Add always_write_timestamps to imaging Add always_write_timestamps conversion option to imaging interfaces Nov 6, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review November 6, 2024 20:14
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (419ab11) to head (d59c19d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
- Coverage   90.59%   90.56%   -0.04%     
==========================================
  Files         129      129              
  Lines        8187     8190       +3     
==========================================
  Hits         7417     7417              
- Misses        770      773       +3     
Flag Coverage Δ
unittests 90.56% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...atainterfaces/behavior/video/videodatainterface.py 93.54% <ø> (-0.09%) ⬇️
...ainterfaces/ophys/baseimagingextractorinterface.py 95.16% <ø> (ø)
src/neuroconv/tools/roiextractors/roiextractors.py 82.41% <100.00%> (+0.18%) ⬆️
src/neuroconv/tools/testing/mock_interfaces.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@h-mayorquin
Copy link
Collaborator Author

As we are updating roiextractors here this should close #1108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant