Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated get_schema_from_method_signature to get_json_schema_from_method_signature #1130

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

h-mayorquin
Copy link
Collaborator

The method was deprecated but we are still using it in many places. This PR corrects that oversight.

@h-mayorquin h-mayorquin self-assigned this Nov 6, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review November 6, 2024 20:23
@weiglszonja
Copy link
Contributor

Looks good to me, did you want to include this in the changlog as well?

@h-mayorquin
Copy link
Collaborator Author

@weiglszonja . Thatnks for the review. I think this does not require a changelog. The function was already deprecated and no functionality is changed. It is more of an internal change. That said, I don't feel that strong about it and can add it to the changelog if you want.

@h-mayorquin h-mayorquin merged commit cbf68d4 into main Nov 7, 2024
43 of 49 checks passed
@h-mayorquin h-mayorquin deleted the remove_deprecated_schema branch November 7, 2024 15:59
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.55%. Comparing base (419ab11) to head (5641c59).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...datainterfaces/ecephys/axona/axonadatainterface.py 50.00% 1 Missing ⚠️
...ecephys/openephys/openephyssortingdatainterface.py 50.00% 1 Missing ⚠️
...tainterfaces/ecephys/spike2/spike2datainterface.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
- Coverage   90.59%   90.55%   -0.04%     
==========================================
  Files         129      129              
  Lines        8187     8187              
==========================================
- Hits         7417     7414       -3     
- Misses        770      773       +3     
Flag Coverage Δ
unittests 90.55% <88.46%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/behavior/lightningpose/lightningposeconverter.py 96.82% <100.00%> (ø)
...rfaces/ecephys/blackrock/blackrockdatainterface.py 95.00% <100.00%> (ø)
.../ecephys/openephys/openephysbinarydatainterface.py 97.29% <100.00%> (ø)
...tainterfaces/ecephys/spikeglx/spikeglxconverter.py 100.00% <100.00%> (ø)
...terfaces/ecephys/spikeglx/spikeglxnidqinterface.py 98.03% <100.00%> (ø)
...onv/datainterfaces/icephys/baseicephysinterface.py 87.09% <100.00%> (ø)
...interfaces/ophys/brukertiff/brukertiffconverter.py 100.00% <100.00%> (ø)
...tainterfaces/ophys/miniscope/miniscopeconverter.py 100.00% <100.00%> (ø)
src/neuroconv/tools/testing/mock_interfaces.py 100.00% <100.00%> (ø)
src/neuroconv/utils/__init__.py 50.00% <ø> (ø)
... and 3 more

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants