Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depth_slice() to ImagingExtractors #231

Closed
wants to merge 8 commits into from
Closed

Conversation

weiglszonja
Copy link
Contributor

Add support for slicing over planes for volumetric imaging data. (first example for volumetric imaging: #230)
WIP

@weiglszonja weiglszonja marked this pull request as draft July 5, 2023 13:19
@pauladkisson
Copy link
Member

This logic should be moved to volumetricimagingextractor.py once #248 is merged.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 79.71%. Comparing base (c5dedb2) to head (1da7855).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   79.17%   79.71%   +0.54%     
==========================================
  Files          39       39              
  Lines        3054     3141      +87     
==========================================
+ Hits         2418     2504      +86     
- Misses        636      637       +1     
Flag Coverage Δ
unittests 79.71% <94.44%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tors/extractors/numpyextractors/numpyextractors.py 65.32% <95.83%> (+4.37%) ⬆️
src/roiextractors/testing.py 98.73% <87.50%> (-0.59%) ⬇️
src/roiextractors/imagingextractor.py 85.29% <95.00%> (+4.04%) ⬆️

@pauladkisson
Copy link
Member

@weiglszonja, are you still working on this?

@weiglszonja
Copy link
Contributor Author

hey @pauladkisson, not actively. do you want to close this for now?

@pauladkisson
Copy link
Member

Yeah, since a lot of this needs to be revamped for volumetric imaging extractor, I think we can close this PR and circle back around to it when we have a concrete reason to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants