Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs #337

Merged
merged 35 commits into from
May 24, 2024
Merged

API docs #337

merged 35 commits into from
May 24, 2024

Conversation

pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented May 22, 2024

Fixes #184

@pauladkisson pauladkisson marked this pull request as draft May 22, 2024 18:21
@pauladkisson pauladkisson marked this pull request as ready for review May 22, 2024 21:48
@CodyCBakerPhD
Copy link
Member

Huh, any clue as to why Inscopix isn't rendering anything? https://roiextractors--337.org.readthedocs.build/en/337/api/imaging_extractors/inscopiximagingextractor.html

@CodyCBakerPhD
Copy link
Member

That's the only one with an issue - otherwise everything else looks fine

@pauladkisson
Copy link
Member Author

Huh, any clue as to why Inscopix isn't rendering anything? https://roiextractors--337.org.readthedocs.build/en/337/api/imaging_extractors/inscopiximagingextractor.html

Renders fine locally...
so thats a little strange...

@CodyCBakerPhD
Copy link
Member

@pauladkisson Another thing to look into that I just noticed, in addition to Inscopix on RTD - the API docs seem to be grabbing and displaying private methods - but do we really want that behavior? Sphinx is supposed to hide those by default apparently (https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#directive-option-automodule-members)

@pauladkisson
Copy link
Member Author

pauladkisson commented May 24, 2024

the API docs seem to be grabbing and displaying private methods

Fixed (just some configuration changes)

Huh, any clue as to why Inscopix isn't rendering anything?

and fixed (roiextractors was incorrectly listed in requirements-rtd.txt so RTD was using the latest release instead of the latest commit).

@CodyCBakerPhD
Copy link
Member

and fixed (roiextractors was incorrectly listed in requirements-rtd.txt so RTD was using the latest release instead of the latest commit).

Ahhh, that's genius lol

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) May 24, 2024 18:10
@CodyCBakerPhD CodyCBakerPhD merged commit 3b670d7 into main May 24, 2024
25 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the api_docs branch May 24, 2024 18:10
@CodyCBakerPhD
Copy link
Member

Looks great!

I actually don't mind the headers provided by the module docs; for a nested or complicated module it could be nice to give a little context at the top of the doc page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: Add API docs
2 participants