Improve error when settings timestamps #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really don't like those tests that check for the assertion comment. I find them hard to hard to maintain as I need to copy-paste and deal with terminal texting issues. |
| f"Mismatch between the number of frames and timestamps: " | ||
| f"{num_frames} frames, but {num_timestamps} timestamps provided. " | ||
| "Ensure the length of 'times' matches the number of frames." | ||
| ) |
There was a problem hiding this comment.
Also good to understand if you have more frames than timestamps or the opposite
alessandratrapani
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this:
#376
Should make more clear what happens when
set_timestampsfails.