Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm builds #2949

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

arm builds #2949

wants to merge 1 commit into from

Conversation

johnnynunez
Copy link

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (914aeec) to head (c589ebd).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2949   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files         198      198           
  Lines        8599     8599           
=======================================
  Hits         7826     7826           
  Misses        773      773           

@ChrisThrasher
Copy link
Collaborator

In my experience, unless you're doing exotic things like using compiler intrinsics and inline assembly, CPU architecture is a non-factor in how I write and test my C++ code. What types of errors do you think these new jobs will catch that the existing CI jobs will not catch?

@johnnynunez
Copy link
Author

johnnynunez commented Feb 6, 2025

In my experience, unless you're doing exotic things like using compiler intrinsics and inline assembly, CPU architecture is a non-factor in how I write and test my C++ code. What types of errors do you think these new jobs will catch that the existing CI jobs will not catch?

Because in H2 a lot of arm devices are coming... (cuda laptops, digits etc)

@ChrisThrasher
Copy link
Collaborator

ChrisThrasher commented Feb 6, 2025

I'm afraid that doesn't really answer my question. The computer hardware market is already full of ARM devices thanks to Apple. I've been using Catch2 on an ARM device for many years. What kinds of errors would these ARM jobs catch that the existing x86 jobs would not catch? My point is that the existing CI pipeline may already be sufficient but I might be missing some of the value of the jobs you added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants