[SL-11 CHORE] part에 generation 속성 추가 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinyoungpark00
approved these changes
Dec 8, 2023
| private String imageUrl; | ||
|
|
||
| @Column(nullable = false) | ||
| private Long curriculumGeneration; |
There was a problem hiding this comment.
다른 필드도 그냥 generation으로 쓰고 있어서 generation으로 하는 것도 좋을 것 같아요
|
|
||
| if (partQuestions.isEmpty() && curriculums.isEmpty()) { | ||
| throw new NoSuchElementException("PartQuestion과 Curriculum이 모두 비어 있습니다."); | ||
| } | ||
|
|
||
| // 임시로 이렇게 구현했습니다. 후에 파트에 generation을 추가하거나 해야할 듯 합니다. | ||
| Long generation = partQuestions.isEmpty() ? curriculums.get(0).getGeneration() : partQuestions.get(0).getGeneration(); |
There was a problem hiding this comment.
part에 generation을 추가했으니 part의 generation을 가져오는 방법도 좋을 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
티켓
SL-11
변경사항
part에 generation 속성을 추가했습니다.
부가설명
고려사항
스크린샷