Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pretty-print function to the Inspector floret #91

Open
brototyp opened this issue Jan 13, 2019 · 1 comment
Open

Add a pretty-print function to the Inspector floret #91

brototyp opened this issue Jan 13, 2019 · 1 comment
Assignees
Labels

Comments

@brototyp
Copy link
Member

brototyp commented Jan 13, 2019

There are some values of a request or a response that are poorly printed or not visible at all. The scope of this ticket is to add an infrastructure to be able to pretty-print data.

Proposal

  • We define a pretty-print ViewController protocol, for example: PrettyPrinter
  • The PrettyPrinter defines a static func viewController(for item: Any) -> UIViewController?
  • A list of PrettyPrinter classes is defined
  • A default mimetype-to-prettyprinter-class mapping is defined
  • If a row for a record is tapped
    • If it is the request or response body, the mimetype mapping is used to find a PrettyPrinter-class
    • If no PrettyPrinter is found, or the PrettyPrinter failed to create a ViewController for that item, the user can select from a list of all PrettyPrinter classes or can chose to share this item
@brototyp brototyp added this to the 2.0 milestone Jan 13, 2019
@brototyp brototyp modified the milestones: Next, 1.0 Feb 17, 2019
pstued added a commit that referenced this issue Mar 3, 2019
pstued added a commit that referenced this issue Mar 3, 2019
@brototyp
Copy link
Member Author

brototyp commented Mar 3, 2019

This issue is only partially implemented.

@brototyp brototyp removed this from the 1.0 milestone Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant