Added a PlaintextPrettyPrinter and manual selection #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstued
reviewed
Feb 25, 2019
Cauli/Florets/Inspector/PrettyPrint/PlaintextPrettyPrinter.swift
Outdated
Show resolved
Hide resolved
brototyp
force-pushed
the
feature/91-pretty-print-in-inspector
branch
from
3b2f131
to
9d54b98
Compare
brototyp
force-pushed
the
feature/91-pretty-print-in-inspector
branch
from
9d54b98
to
2d7ebb0
Compare
brototyp
changed the title
Generated by 🚫 Danger |
|
@pstued This PR isn't WIP anymore and can finally be reviewed 😊 |
pstued
approved these changes
Mar 3, 2019
…d by an endless loop
pstued
force-pushed
the
feature/91-pretty-print-in-inspector
branch
from
619ee06
to
78ffcd3
Compare
# Conflicts: # CHANGELOG.md # Cauliframework.xcodeproj/project.pbxproj # Example/cauli-ios-example/Pods/Pods.xcodeproj/project.pbxproj
brototyp
force-pushed
the
feature/91-pretty-print-in-inspector
branch
from
88472ca
to
c6f29ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the first steps towards #91. For now I skipped automatic selection of the "correct" pretty printer. It will just display a
UIAlertControllerand lets the user select the pretty printer.Screenshots