Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where table get under the toolbar on scrolling in inspect… #204

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kaynewcomer
Copy link

@kaynewcomer kaynewcomer commented Mar 24, 2020

No description provided.

@brototyp-bot
Copy link

1 Error
🚫 Please include a CHANGELOG entry to credit yourself!
You can find it at /CHANGELOG.md.
4 Warnings
⚠️ Are there any changes that should be explained in the README.md?
⚠️ Cauli/Florets/Inspector/Record List/InspectorTableViewController.swift#L68 - Variable name should be between 3 and 40 characters long: ‘y’
⚠️ Cauli/Florets/Inspector/Record List/InspectorTableViewController.swift#L118 - Top-level declarations should specify Access Control Level keywords explicitly.
⚠️ Cauli/Florets/Inspector/Record List/InspectorTableViewController.swift#L131 - Top-level declarations should specify Access Control Level keywords explicitly.

Example CHANGELOG entry

* **feature/improvement/bugfix** Fixed a bug where table get under the toolbar on scrolling in inspect…  
  [#issue_number](https://github.com/cauliframework/cauli/issues/issue_number) by @kaynewcomer  

Trivial PR?

If you think your PR is trivial and neither a CHANGELOG entry nor a README update is necessary, you can add a #trivial to your PR title. The bot will pick that up and will not warn about a missing CHANGELOG or README entry.

Generated by 🚫 Danger

@thorstenstark
Copy link
Collaborator

Any updates on this here @brototyp @pstued ?

@brototyp
Copy link
Member

Thanks for the bump! It wasn't on my radar at all. I'll try to check it this weekend.

@brototyp
Copy link
Member

Hi @kaynewcomer and @thorstenstark,

thanks for the PR and the involvement. Unfortunately I can't find the bug this PR is fixing. At least in the example app the development branch works fine.

Can you come up with reproduction steps, if possible things that are different in the example app, so I can reproduce them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants