Added the MapRemoteFloret #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brototyp
commented
Mar 13, 2021
Generated by 🚫 Danger |
brototyp
force-pushed
the
feature/216-map-remote-floret
branch
from
0d7d30d
to
4219b6f
Compare
brototyp
force-pushed
the
feature/216-map-remote-floret
branch
from
4219b6f
to
e614401
Compare
brototyp
force-pushed
the
feature/216-map-remote-floret
branch
from
9d751d8
to
7aef63b
Compare
pstued
reviewed
Mar 14, 2021
brototyp
force-pushed
the
feature/216-map-remote-floret
branch
from
3367aa9
to
a8901f9
Compare
Oh man. How embarrassing. Thanks! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the MapRemoteFloret and thus implements the first step towards #216.
I did not yet implement the XML parsing yet and wanted to open up the discussion on how we should do that.