refactor(structure): restructure code so we can properly support many… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this-is-sofia
approved these changes
Jan 2, 2024
|
|
||
| class AbstractGraphModel(GraphModelInterface, ABC): | ||
| """ | ||
| The graph model is the main class of causy. It is responsible for creating a graph from data and executing the pipeline_steps. |
There was a problem hiding this comment.
I think you mean: The graph model is the main class of causy. It is responsible for initialising nodes for each variable that we have data from, then initializing a fully connected graph by adding edges between each pair of these nodes and then executing the pipeline_steps.
| The graph model is the main class of causy. It is responsible for creating a graph from data and executing the pipeline_steps. | ||
|
|
||
| The graph model is responsible for the following tasks: | ||
| - Create a graph from data (create_graph_from_data) |
There was a problem hiding this comment.
"create nodes for each variabel" or "initialise a fully connected graph"
| """ | ||
| Take the actions returned by the test | ||
|
|
||
| In causy changes on the graph are not executed directly. Instead, the test returns an action which should be executed on the graph. |
There was a problem hiding this comment.
test -> independence test or orientation rule
| Take the actions returned by the test | ||
|
|
||
| In causy changes on the graph are not executed directly. Instead, the test returns an action which should be executed on the graph. | ||
| This is done to make it possible to execute the tests in parallel as well as to decide proactively at which point in the decisions taken by the pipeline step should be executed. |
There was a problem hiding this comment.
"at which part in the decision": minus in I think
|
|
||
| In causy changes on the graph are not executed directly. Instead, the test returns an action which should be executed on the graph. | ||
| This is done to make it possible to execute the tests in parallel as well as to decide proactively at which point in the decisions taken by the pipeline step should be executed. | ||
| Actions are returned by the test and are executed on the graph. The actions are stored in the action history to make it possible to revert the actions or use them in a later step. |
There was a problem hiding this comment.
test -> pipeline step? independence test or orientation rule? (it's not only tests)
| This is done to make it possible to execute the tests in parallel as well as to decide proactively at which point in the decisions taken by the pipeline step should be executed. | ||
| Actions are returned by the test and are executed on the graph. The actions are stored in the action history to make it possible to revert the actions or use them in a later step. | ||
|
|
||
| :param results: |
There was a problem hiding this comment.
the results of the tests and rules
| Actions are returned by the test and are executed on the graph. The actions are stored in the action history to make it possible to revert the actions or use them in a later step. | ||
|
|
||
| :param results: | ||
| :return: |
|
|
||
| def execute_pipeline_step(self, test_fn: PipelineStepInterface): | ||
| """ | ||
| Execute a single pipeline_step on the graph. either in parallel or in a single process depending on the test_fn.parallel flag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… algorithms