Skip to content

Commit

Permalink
Update comment after discussion in data-apis#279
Browse files Browse the repository at this point in the history
  • Loading branch information
cbourjau committed Oct 25, 2023
1 parent 42d454a commit 33c39c8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions spec/API_specification/examples/03_sklearn_like_pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ def fit(self, df: DataFrame) -> Self:
scalings = scalings.collect()

self.scalings_ = {
# Clarify: Should the return type of `get_value` (lazy /
# eager scalar) depend on a previous call to `collect`?
# Note: `get_value` returns an implemenation-defined,
# duck-typed scalar which may be lazy.
column_name: scalings.get_column_by_name(column_name).get_value(0)
for column_name in self.column_names
}
Expand Down

0 comments on commit 33c39c8

Please sign in to comment.