Switch to two retro VU Meters for stereo instead of downmixing to mono #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed merge conflicts
…b needle position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retro VU meter showed only the max value of both channels. I thought it would be nice to have 2 VU meters, one for each stereo channel. I also replaced the vumeter.png (and added a vumeterStereo.png) with a higher quality one and moved its path to
$HOME/.local/lib/deadbeef/as the plugin also has to be in that folder and i did not like to have the single vumeter.png directly in my home folder.this PR also incorporates #2 because i merged it with my fork and i dont know how to only submit the stereo changes as a PR