Merge pull request chrisvfritz#232 from cbravo/feat-error-handling

feat(errors): adds error handling that will terminate the node process.
cbravo · Aug 14, 2018 · 1d6188e · 1d6188e
2 parents 995aebc + 6b7f2b3
commit 1d6188e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/es5-autogenerated/index.js b/es5-autogenerated/index.js
@@ -154,7 +154,8 @@ PrerenderSPAPlugin.prototype.apply = function (compiler) {
     }).catch(function (err) {
       PrerendererInstance.destroy();
       console.error('[prerender-spa-plugin] Unable to prerender all routes!');
-      throw err;
+      compilation.errors.push(new Error('[prerender-spa-plugin] Unable to prerender all routes!'));
+      done();
     });
   };
 

diff --git a/es6/index.js b/es6/index.js
@@ -143,8 +143,9 @@ PrerenderSPAPlugin.prototype.apply = function (compiler) {
       })
       .catch(err => {
         PrerendererInstance.destroy()
-        console.error('[prerender-spa-plugin] Unable to prerender all routes!')
-        throw err
+        console.error('[prerender-spa-plugin] Unable to prerender all routes!');
+        compilation.errors.push( new Error( '[prerender-spa-plugin] Unable to prerender all routes!' ) );
+        done();
       })
   }