-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix export #177
Fix export #177
Conversation
Can you give an example where the current implementation gives an error? |
try to export file->export (all functions does not have a ffilter arg) |
Ah OK! Hmm, when did I break this? It seems like the export mechanism is overly complicated, I have to figure out what all this extension and ffilter stuff does and if it is really necessary. |
I agree it could be cleaner. (I suggest just a workaround for the bug) ;) |
Yes, at some point the exporting functionality should be refactored, but for now we need a workaround. Would it be simpler to just add the |
I'm not sure it is better in terms of design. |
I've created #178 to discuss this. |
Thanks @gdolle! |
This PR should solve issue #176