covHisto_WG needs to be long[] to not overflow #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When computing a histogram across the whole genome, you'll need to use an array of longs to avoid integer overflow (so you don't get a histogram that says that -1414732325 bases were at zero coverage, for instance). I notice that the basesWithOneHitorMore_WG variable and others like it were changed to longs instead of ints, so that's good. On the other hand, it might make more sense to just compute those from the histogram instead of keeping individual tallies as you go along.
|
Hi, Yes we did notice that and have addressed that. We are going to push it with other changes. Thank you for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing a histogram across the whole genome, you'll need to use an array of longs to avoid integer overflow (so you don't get a histogram that says that -1414732325 bases were at zero coverage, for instance).
I notice that the basesWithOneHitorMore_WG variable and others like it were changed to longs instead of ints, so that's good. On the other hand, it might make more sense to just compute those from the histogram instead of keeping individual tallies as you go along.