Check HTTP header size #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good idea but where did you come up with the number 200,000? I have doubts about that number. In fact, while it seems there is a limit on the size of the request header, it's not clear to me that there is any such restriction on response headers. Even if there is, it seems the restriction should be on the cumulative size of all headers, not just one of them. |
|
cc @ccampbell |
|
I´ve just posted a pull request with the solution for this problem. If the header exceeds 8k the user will reveive an error message from ChromePHP on the log, instead of an 500 Interval server error. |
|
This was addressed in the PR of my fork: PHPExpertsInc/chromephp#2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.