Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PHP_VERSION and version_compare() where appropriate #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okonomiyaki3000
Copy link

We don't need to store $_php_version because there is already PHP_VERSION. version_compare() is the correct way to compare or test version numbers.

Also, I didn't remove it here, but $_timestamp seems to be unused. Do we actually need this value for any reason?

@okonomiyaki3000
Copy link
Author

Thanks @DanMan

This is a great library but has it been abandoned?

@DanMan
Copy link

DanMan commented Feb 3, 2017

YW @okonomiyaki3000 . Judging from the commit history, yes. Maybe you can put your fork on packagist.org ? I think it might be the most complete.

It's a shame that this isn't a drop-in replacement for FirePHP. At least the enable/disable switch would be very useful. I've currently wrapped this one in another shallow class of my own to accomplish that.

@hopeseekr
Copy link

hopeseekr commented May 15, 2019

@okonomiyaki3000 I merged this PR into my own fork of chromephp so that your work wouldn't be completely in vain. But honestly? comparing PHP 5.3 and 5.1? Damn, this code has rotted!

I scarcely even remember the days when ReflectionMethod::setAccessible() didn't even exist (pre-5.3.2!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants