Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #45

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Refactor #45

wants to merge 11 commits into from

Commits on Apr 1, 2014

  1. Add a setting for base-path so that only the relevant parts of the fi… 

    …le path need be shown in the console.
    @okonomiyaki3000
    okonomiyaki3000 committed Apr 1, 2014
    Configuration menu
    Copy the full SHA
    3d1bd4d View commit details
    Browse the repository at this point in the history

  2. _log returns the class instance for method chaining

    @okonomiyaki3000
    okonomiyaki3000 committed Apr 1, 2014
    Configuration menu
    Copy the full SHA
    60224bb View commit details
    Browse the repository at this point in the history

  3. Hmm. No reason to get the instance again when we already have it, eh?

    @okonomiyaki3000
    okonomiyaki3000 committed Apr 1, 2014
    Configuration menu
    Copy the full SHA
    85f83f6 View commit details
    Browse the repository at this point in the history

  4. use magic methods

    @okonomiyaki3000
    okonomiyaki3000 committed Apr 1, 2014
    Configuration menu
    Copy the full SHA
    628eaee View commit details
    Browse the repository at this point in the history

  5. Update the docblock return value, always return , use empty instead o… 

    …f count, use array_map instead of foreach, call isset with multiple args
    @okonomiyaki3000
    okonomiyaki3000 committed Apr 1, 2014
    Configuration menu
    Copy the full SHA
    0b3af50 View commit details
    Browse the repository at this point in the history

  6. change constant names everywhere

    @okonomiyaki3000
    okonomiyaki3000 committed Apr 1, 2014
    Configuration menu
    Copy the full SHA
    706921f View commit details
    Browse the repository at this point in the history

  7. use PHP_VERSION and version_compare() where appropriate

    @okonomiyaki3000
    okonomiyaki3000 committed Apr 1, 2014
    Configuration menu
    Copy the full SHA
    397dadf View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2014

  1. Merge branch 'version_compare' into refactor

    @okonomiyaki3000
    okonomiyaki3000 committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    bcf1fd7 View commit details
    Browse the repository at this point in the history

  2. fix merge issue

    @okonomiyaki3000
    okonomiyaki3000 committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    dbaae94 View commit details
    Browse the repository at this point in the history

  3. fix merge issue

    @okonomiyaki3000
    okonomiyaki3000 committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    5016504 View commit details
    Browse the repository at this point in the history

  4. more refactoring

    @okonomiyaki3000
    okonomiyaki3000 committed Apr 2, 2014
    Configuration menu
    Copy the full SHA
    0b29b2c View commit details
    Browse the repository at this point in the history