Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Classic ASP language #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michelepisani
Copy link

Code syntax highlighting for Classic ASP

Code syntax highlighting for Classic ASP
@ccampbell
Copy link
Owner

Hi there,

I am sorry for not working on this project in so long. I am back to it now, and have just released version 2.0. I'd be happy to merge this, but first could you do a few things:

  • Update this to be compatible with Rainbow 2.0

    This will require you to update your branch from upstream and then move the file to src/language/asp.js. Then you will have to add 'generic' as the second argument to the Rainbow.extend call (previously it was assumed that languages would inherit from generic).

  • Add some unit tests for ASP in the test/language directory. Instructions for running tests are available in the README and you can look at other files for examples.

@ccampbell ccampbell mentioned this pull request Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants