-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite compile.bat and Update GA workflow to build binaries on Windows: Use Git Version, Use MSBuild, and Allow custom Boost and MSBuild paths #395
Conversation
Previously, the versions of the project, and the versions and locations of boost library were all hard-coded in the vcxproj files. This PR updates the build approach for Windows executables (vina.exe and vina_split.exe):
This is also available
The artifact has version information similar to this:
.\compile.bat Release x64 "C:\local\boost_1_83_0\lib64-msvc-14.2" "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\MSBuild.exe" "$env:GIT_VERSION" Here, 5 variables are passed in order to specify:
An installation guide can be added to documentation, when this is in release. Building on WIndows with this approach currently requires:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test this personally, but since the tests pass I'll assume everything works ok.
@@ -23,7 +23,7 @@ on: | |||
|
|||
jobs: | |||
compile_binaries: | |||
name: Build wheels on ${{ matrix.os }} ${{ matrix.arch }} | |||
name: Compile binaries on ${{ matrix.os }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this as it is, reporting both the os and arch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have specifc name including arch for each step. The generic name here might not apply. Here because we didn't define arch type for windows (not sure why though..) this might fail. I can try though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right that the name still shows up in the log file. The individual job name follows the name of each step. I will make the correction. I can improve the names
Thanks! I can test on two more Windows computers with slightly different configurations. |
Tested on two more systems to make sure compile.bat can compile on older systems without powershell. Made a small change in 3ba69f1 to allow compilation with different versions of msvc. Previously, msvc-v142 is hardcoded in vcxproj and it works for Visual Studio 2019 (v16.x). As of today, the official website is featuring Visual Studio 2022 (v17.x) and build tools, which need msvc-143. This is ready :D can be merged any time. thanks!! |
This is a renovation of current build approach on Windows. To address Issue #390.
Expect to add an installation note in doc for people who want to build binaries on Windows.