Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfel merge filter by resolution n obs #1030

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dwmoreau
Copy link
Contributor

@dwmoreau dwmoreau commented Dec 2, 2024

Implemented experiment filters by resolution and number of observations within cctbx.xfel.merge

@dwmoreau dwmoreau requested a review from phyy-nx December 2, 2024 15:36
@phyy-nx phyy-nx force-pushed the xfel_merge_filter_by_resolution_n_obs branch 2 times, most recently from b947567 to 4ca6c71 Compare December 2, 2024 22:01
Copy link
Contributor

@phyy-nx phyy-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good feature. Some review comments added.

xfel/merging/application/phil/phil.py Outdated Show resolved Hide resolved
xfel/merging/application/phil/phil.py Outdated Show resolved Hide resolved
@dwmoreau dwmoreau force-pushed the xfel_merge_filter_by_resolution_n_obs branch from 244f829 to 5a94912 Compare January 9, 2025 17:05
@phyy-nx phyy-nx force-pushed the xfel_merge_filter_by_resolution_n_obs branch from 5a94912 to a33ac15 Compare January 9, 2025 23:06
@phyy-nx phyy-nx force-pushed the xfel_merge_filter_by_resolution_n_obs branch from a33ac15 to 5fef2c6 Compare January 10, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants