Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "Advanced" flake template #21

Closed
wants to merge 3 commits into from

Conversation

silky
Copy link
Contributor

@silky silky commented Apr 29, 2023

Fixes #18

This is a draft @cdepillabout because I'm not sure if it's a great idea; interested in feedback.

Pros:

  • Well, it's a flake template, and you can run nix flake init --template ~/dev/stacklock2nix#advanced to install it.
  • It can be built with any of the "expected" mechanisms.

Cons:

  • In order to make it build, I had to copy in an entire stack project skeleton.
  • It's pinned to a specific LTS,
  • A dummy some-app name is a bit polluted all over the place.
  • It duplicates a bit code that's already in the repo; in terms of say this example (maybe we should just turn that into the template?)
  • I do an opinionated thing with cabal, (make it call hpack first) that people might not like.

Maybe, upon reflection, a stack template (from a URL) would be more stack-idiomatic, as at least then some of those variables can be set around in various places in the nix files.

TODO:

  • Decide if this is a good idea or not
  • Resolve todo notes in code

Open to opinions ...

@silky
Copy link
Contributor Author

silky commented May 16, 2023

@cdepillabout Closing this just to not leave it stale; but let me know if you have any thoughts on how to move forward in a way that you would prefer!

@silky silky closed this May 16, 2023
@cdepillabout
Copy link
Owner

cdepillabout commented May 16, 2023

@silky Hey sorry, I've been pretty busy the last couple weeks. I do have reviewing this PR on my TODO list, but I may not get to it for another two weeks or so.

Feel free to leave it open though. Or if you'd rather close it, I can reopen it when I get to it.

@silky silky reopened this May 16, 2023
@silky silky force-pushed the flake-templates branch from 270296f to a842485 Compare May 18, 2023 08:47
@silky
Copy link
Contributor Author

silky commented Jul 12, 2023

Closing; I think it's fair to say this isn't the way to go.

@silky silky closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a (stack?/nix?/?) template for the simple/advanced project starting points
2 participants