Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to using audiotags for better compatibility #78

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Ralim
Copy link

@Ralim Ralim commented Jul 20, 2023

Hello 👋🏼 ,
I wanted to use this on FLAC files and it didnt yet work.
I've done this base pass conversion over to audiotags. It seems to work nicely for me here.
However audiotags doesnt support the comment field so not sure how to handle the filter for fixer_is_blacklisted.
Would love your comments on how you would prefer to move forward for using it.
Looking in the trait AudioTagEdit; there is no nicely exposed option for us to use.

Would close #36

@Ralim Ralim marked this pull request as ready for review July 20, 2023 01:37
@cdown
Copy link
Owner

cdown commented Jul 25, 2023

Hey! I actually added comment support to audiotags in preparation for this a few months ago, but there has been no release since: TianyiShi2001/audiotags@b6b3df1

So the first step would be to have them do a release. Thanks for looking at this! :-)

@Ralim
Copy link
Author

Ralim commented Jul 25, 2023

Ah well then that would be excellent.
Should you/me/both of us ask for a release over there?
Happy to update this once we get a release 😁

@cdown
Copy link
Owner

cdown commented Dec 2, 2023

Looks like a release is close: TianyiShi2001/audiotags#40

@pinkforest
Copy link

fyi the release happened

@Bide-UK
Copy link

Bide-UK commented Jun 12, 2024

bump also want to use this one flac

@Ralim
Copy link
Author

Ralim commented Jul 25, 2024

I've updated the PR to use the latest audiotags release and comments.
@cdown Would appreciate a review when you have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to use audiotags
4 participants