Fix to prefetch example, for userId #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #410 The `context.userId` field is (somewhat recently) defined to contains the FHIR resource name and identifier. For example, this field should contain: `Practitioner/123`. This was done to explicitly support scenarios other than provider-facing, for example, the user could be `Patient/456' or `Person/789` (following the [user-to-FHIR mapping](smart-on-fhir/smart-on-fhir.github.io#148)) that SMART negotiated. Because of this change, the prefetch example of `Practitioner/{{context.userId}}` would translate into `Practitioner/Practitioner/123` as issue #410 points out. This PR simply removes the "Practitioner/" string from the example, in lieu of the alternative, breaking changes suggested in #410.
brynrhodes
approved these changes
Dec 21, 2018
|
Aren't both the options "breaking" changes though? |
|
Isaac explained this to me - I'm okay with going ahead with this plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #410
The
context.userIdfield is (somewhat recently) defined to contains the FHIR resource name and identifier. For example, this field should contain:Practitioner/123. This was done to explicitly support scenarios other than provider-facing, for example, the user could bePatient/456' orPerson/789` (following the user-to-FHIR mapping) that SMART negotiated.Because of this change, the prefetch example of
Practitioner/{{context.userId}}would translate intoPractitioner/Practitioner/123as issue #410 points out.This PR simply removes the "Practitioner/" string from the example, in lieu of the alternative, breaking changes suggested in #410.