fix(keywords): some KID items were breaking certain active effects #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are just logging for now, but that will help.
If we didn't have it in cache, we don't care about a count change.
The repro case is fixed, anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Ashen and PO3 on the skyrimmods discord, who directed me to the KID file as a possible cause for this. I narrowed it down to a handful of lines that cause this side effect with active effects, and disabled anything that looks like those.
I'd rather give some items generic icons than cause gameplay bugs.
The rest of this PR is cleanup I did while investigating the bug.
This fixes #117 and very likely also fixes #81 .