feat(layouts): text truncation & proper text alignment #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you add set truncate to true in a text element, like this: ```toml wrap_width = 130.0 truncate = true ``` The text is truncated at the given wrap width instead of wrapped. Strictly speaking we should change the field `wrap_width` to `width`, but I fear breaking existing layouts. Dry-coded, so it's not going to work, but hey. Why change my habits now? This should fix #104 when it lands.
Had to use CalcTextSizeA() to do this. I now have the primitives with which to implement aligned text wrapping, so I'll do that next.
Lol, as they say. Lmao.
Left-aligned lines go through the built-in imgui line-breaking algorithm. For right- and center-aligned lines, we let imgui tell us where the line would break to hit max width, then walk left a few characters to find the nearest space if one exists. If we find one, we use that to break and recalculate our bounds. If we don't, we use what imgui suggested. This looks good for all of the cases, I believe. Hooray!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now set
truncateto true in a text element, like this:The text is truncated at the given wrap width instead of wrapped.
While I was truncating text and just generally figuring out what these
imgui functions do, I returned to the problem of correctly-aligning
wrapped text. For right- and center-aligned text, this requires
looping through the full text rendering it one line at a time,
adjusting the position of each line to match its bounds. Further,
because imgui does not export any of its word-wrapping implementation,
we have to do additional work to find word boundaries. To do this,
we look for the nearest space preceding the imgui-selected wrap position.
If it's near enough, we break the line at that position, recalculate
bounds, and draw.
I broke out the text rendering cases so that simple cases do the least
work possible, and the space-seeking and bounds-adjusting work is only
done when required. The implementation of drawing text is somewhat
verbose as a result but each case is simple by itself.
Fixes #104
Fixes [#98]