Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for colon for time when searching for time #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

djrcawley
Copy link

@djrcawley djrcawley commented Jun 9, 2023

image

Check for colon when scraping and converting to date-time. Airline LATAM creates a Value Error when we check solely for 'AM' and 'PM'

@djrcawley
Copy link
Author

djrcawley commented Jun 15, 2023

Hello,

I'm still pretty new to github and want to contribute where I can, so I apologize if my formatting is not the best. The issue I found, while very small, occurs anytime the airline LATAM is scraped. Since args checks for strings containing "AM" and formats them to a datetime. Instead, I added another check to verify if a colon was included in each string before it is formatted to a datetime.

Let me know if you have any other suggestions. I know this isn't a major issue, but hoped to still contribute anyways. @kcelebi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant