feat: use a dynamic timeout commit modelled on the size of the block #1342
Conversation
| blockSizeBytes = maxBlockSize | ||
| } | ||
|
|
||
| timeoutCommit := cfg.TimeoutCommit - (time.Duration(blockSizeBytes) * perByteDelay) |
There was a problem hiding this comment.
what would be the best of determining this value? I guess adjusting on mocha?
would you describe the upside being simplicity and the downside being that changes to the network require re-calibrating this value?
There was a problem hiding this comment.
Yes, this function should be determined empirically by running 100 node networks with varying block sizes from 0MB to 8MB and modelling that into a function.
would you describe the upside being simplicity and the downside being that changes to the network require re-calibrating this value?
Yes it's a good simple temporary solution. If we go down the road of either compact blocks or proposer based timestamps. Those solutions can replace this current one
|
can we close this draft for now? |
Co-authored-by: Philip Offtermatt <[email protected]> Co-authored-by: lasaro <[email protected]> Co-authored-by: Sergio Mena <[email protected]>
This is meant to show a quick way for implementing a dynamic timeout commit aimed at achieving more consistent block times. The approach is to model how the size of the block effects commit speed. This example PR uses a 8MB block as the upper bound which would reduce the timeout commit propotionally by up to 4 seconds. We obviously need to model what linear formula best fits the celestia network.