chore: add recovery message types #1608
Open
+3,041
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
WS: Big Blonks 🔭
rach-id
approved these changes
Feb 12, 2025
consensus/propagation/types.go
Outdated
| } | ||
|
|
||
| // ToProto converts PartMetaData to its protobuf representation. | ||
| type HavePart struct { |
There was a problem hiding this comment.
should this be HavePart or HaveParts?
evan-forbes
requested review from
rootulp and
ninabarbakadze
and removed request for
a team
|
I'll defer to you @rach-id on when its okay to merge to the feature branch |
rach-id
approved these changes
Feb 12, 2025
| "github.com/tendermint/tendermint/types" | ||
| ) | ||
|
|
||
| // TxmetaData keeps track of the hash of a transaction and its location with the |
There was a problem hiding this comment.
Suggested change
| // TxmetaData keeps track of the hash of a transaction and its location with the | |
| // TxMetaData keeps track of the hash of a transaction and its location within the |
Comment on lines
+16
to
+17
| Start uint32 | ||
| End uint32 |
There was a problem hiding this comment.
[nit]
would be nice to specify how inclusive/exclusive there ranges are. Maybe just a comment saying that the range is [start, End)
Comment on lines
+41
to
+43
| if t.Start > t.End { | ||
| return errors.New("TxMetaData: Start > End") | ||
| } |
| type CompactBlock struct { | ||
| Height int64 `json:"height,omitempty"` | ||
| Round int32 `json:"round,omitempty"` | ||
| BpHash []byte `json:"bp_hash,omitempty"` |
There was a problem hiding this comment.
[nit]
what does bpHash stand for? maybe a comment specifying it's the block propagation hash
Comment on lines
+114
to
+115
| // index, along with the proof of inclusion to either the PartSetHeader hash or | ||
| // the BPRoot in the CompactBlock. |
There was a problem hiding this comment.
how do we know whether this part's proof is for the partsetheader or the bproot?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
still needs validate basic and tests