-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RetrieveBlockData as described by ADR 002 #232
Merged
Merged
Changes from 23 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
3c24d62
implement GetLeafData
evan-forbes 1f12d6b
use a real ipfs node instead of a mocked one during testing
evan-forbes d8f9190
Merge branch 'master' into evan/read-ipfs
evan-forbes 1a5f9e3
use the ResolveNode method of the ipfs api instead of dag get
evan-forbes b69c0af
update CalcCIDPath tests
evan-forbes 6dff524
first draft of RetrieveBlockData implementation
evan-forbes 25a521d
Merge branch 'master' into evan/RetrieveBlockData
evan-forbes e692b0e
remove the parser interface
evan-forbes 0d6b0f5
Merge branch 'master' into evan/RetrieveBlockData
evan-forbes e4be5d4
refactor leaf counter, fix bug
evan-forbes 1b2335a
remove prints
evan-forbes 28c6dee
update to the latest commit of rsmt2d
evan-forbes ca8c5b2
refactor RetrieveBlockData and fix bugs
evan-forbes cc7b7c4
increase test timeouts for CI
evan-forbes 0b8c2ca
increase timeouts again :disappointed:
evan-forbes baf2fcc
add polish and change up timeouts for CI
evan-forbes af6a815
fix typo causing tests to fail
evan-forbes d10e141
revert remnant of debugging
evan-forbes 60afd13
polish
evan-forbes 4199979
re adjust timeouts
evan-forbes bb7fd2f
even longer timeout
evan-forbes f5677be
add buffer to hopefully help CI
evan-forbes 152bb82
polish
evan-forbes 98e1d72
Merge branch 'master' into evan/RetrieveBlockData
evan-forbes ffe1719
don't pin data to ipfs during testing
evan-forbes 92e4132
use max block size
evan-forbes eba479b
retrieve block with minimum number of ipfs requests
evan-forbes 0879f7a
go mod tidy + use cyrpto/rand instead of math/rand
evan-forbes 43d420b
add no lint directive to weak random number generator
evan-forbes 0510c67
set absurd timeout
evan-forbes 69a7037
only run large tests with the race detector of
evan-forbes 48360ca
review feedback: better docs
evan-forbes 20d4c19
review feedback: better docs
evan-forbes 50b691e
review feedback: smoother test sorting for a large tests
evan-forbes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of these asci-art separators. if there is a larger chunk of logic that needs to be separated, files or packages are the way we should ideally structure these. IMO, let's change this in this PR but take care of this in a follow-up PR instead.