feat(shwap/bitswap): add blockstore metrics #3862
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
added
kind:feat
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3862 +/- ##
==========================================
+ Coverage 44.83% 45.26% +0.42%
==========================================
Files 265 309 +44
Lines 14620 22145 +7525
==========================================
+ Hits 6555 10023 +3468
- Misses 7313 11050 +3737
- Partials 752 1072 +320 ☔ View full report in Codecov by Sentry. |
Wondertan
reviewed
Oct 21, 2024
| getSize metric.Int64Counter | ||
| put metric.Int64Counter | ||
| putMany metric.Int64Counter | ||
| allKeysChan metric.Int64Counter |
There was a problem hiding this comment.
We dont need this one realistically. We dont implement it and never call it
There was a problem hiding this comment.
The blockstore metrics are design as general purpose wrapper. Metrics wrapper is also used for Light node blockstore, which implements those operations.
cristaloleg
reviewed
Nov 20, 2024
cristaloleg
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add telemetry for server side of bitswap (blockstore) operations.