feat!(core): enable tls for grpc connection #3922
Open
+203
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3922 +/- ##
==========================================
+ Coverage 44.83% 45.32% +0.49%
==========================================
Files 265 309 +44
Lines 14620 21974 +7354
==========================================
+ Hits 6555 9960 +3405
- Misses 7313 10937 +3624
- Partials 752 1077 +325 ☔ View full report in Codecov by Sentry. |
vgonkivs
changed the title
vgonkivs
added
kind:break!
vgonkivs
requested review from
renaynay,
Wondertan,
walldiss and
cristaloleg
as code owners
treethought
reviewed
Nov 13, 2024
nodebuilder/core/config.go
Outdated
| // It should not include file names('cert.pem' and 'key.pem'). | ||
| // If left empty, the client will be configured for an insecure (non-TLS) connection. | ||
| TLSPath string | ||
| // XTokenPath specifies the file path to the JSON file containing the X-Token for gRPC authentication. |
There was a problem hiding this comment.
comments say this is path to the JSON file, but due to the use of the xtoken const, needs to be the path to the directory containing a file named xtoken.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all changes from #3917.
The PR introduces 2 additional fields in the core config and 2 cli flags that allow to configure these fields.