Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header)!: use tmjson encoding for Commit field as well #3925

Closed
wants to merge 1 commit into from

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Nov 7, 2024

Fixes #3918

Please note: this PR is BREAKING as header encoding has changed.

I don't see a reason we weren't doing this to begin with as we tmjson encode the other "tendermint" fields.

@renaynay renaynay added area:header Extended header kind:break! Attached to breaking PRs area:api Related to celestia-node API labels Nov 7, 2024
@renaynay renaynay self-assigned this Nov 7, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 45.10%. Comparing base (2469e7a) to head (5ebb191).
Report is 378 commits behind head on main.

Files with missing lines Patch % Lines
header/header.go 50.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3925      +/-   ##
==========================================
+ Coverage   44.83%   45.10%   +0.27%     
==========================================
  Files         265      307      +42     
  Lines       14620    21846    +7226     
==========================================
+ Hits         6555     9854    +3299     
- Misses       7313    10912    +3599     
- Partials      752     1080     +328     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should tmjson the whole ExtendedHeader altogether, without aliasing and individual calls for each field

@renaynay renaynay marked this pull request as draft November 7, 2024 16:31
@renaynay renaynay closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Related to celestia-node API area:header Extended header kind:break! Attached to breaking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization inconsistency between celestia-node API and Tendermint API
3 participants