misc(state/core_accessor): add retry logic for creating a txClient

[vgonkivs]

Create a txClient in runtime if it was initialized during the startup

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 52.38095% with 20 lines in your changes missing coverage. Please review.

Project coverage is 44.79%. Comparing base (2469e7a) to head (a2b1919).
Report is 428 commits behind head on main.

Files with missing lines	Patch %	Lines
state/core_access.go	52.38%	14 Missing and 6 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4053      +/-   ##
==========================================
- Coverage   44.83%   44.79%   -0.05%     
==========================================
  Files         265      308      +43     
  Lines       14620    22456    +7836     
==========================================
+ Hits         6555    10059    +3504     
- Misses       7313    11312    +3999     
- Partials      752     1085     +333     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[renaynay]

why not just try to set it up in getSigner if it's == nil ?

[vgonkivs]

getSigner parses the TxConfig(signer is not required to be a defaultAccount) which is not the same as creating a client. I actually haven't thought about doing it there. If you have a strong opinion about it, I can definetely create it there.

[renaynay]

My point is getSigner is called everywhere where the signer is needed, so why can't we lazy re-init in there if signer == nil ?

[vgonkivs]

signer != txClient. Signer is a property of TxConfig in that context and it can be nil: this means that defaultAccount will sign the transaction. txClient is used in two places: submitPayForBlob(for blob submission) and submitMsg(for all other Write transactions).

[renaynay]

@vgonkivs I mean why can't we have the same logic (ca.getTxClient()) to either return already-initialised client or try to lazy re-init the client?

so instead of on #L122 instead of calling setupTxClient, there's a fucntion

getTxClient() which checks if ca.client !=nil, returns the client, but if nil, then it tries to set it up.

[vgonkivs]

Ah, ok. I did not get your initial idea. Sorry. will rework it.

[cristaloleg]

SGTM