Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove Rosetta test. #105

Merged
merged 1 commit into from
Apr 12, 2022
Merged

chore: Remove Rosetta test. #105

merged 1 commit into from
Apr 12, 2022

Conversation

adlerjohn
Copy link
Member

Remove rosetta test. It's related to Coinbase's Rosetta, which we don't need at this time.

@adlerjohn adlerjohn self-assigned this Apr 12, 2022
@adlerjohn adlerjohn changed the title Remove Rosetta test. chore: Remove Rosetta test. Apr 12, 2022
liamsi
liamsi reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this for mainnet as far as I remember though. I'm ok with removing this for now but mind opening an issue and triage it to incentivized testnet/mainnet then?

@adlerjohn adlerjohn mentioned this pull request Apr 12, 2022
Open
@adlerjohn
Copy link
Member Author

Done in #108

@adlerjohn adlerjohn requested a review from liamsi April 12, 2022 12:02
@adlerjohn adlerjohn merged commit 3eb616d into release/v0.44.x-celestia Apr 12, 2022
@adlerjohn adlerjohn deleted the adlerjohn/remove-rosetta branch April 12, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes evan-forbes is a code owner

Assignees

@adlerjohn adlerjohn

Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adlerjohn @liamsi