Implement Balance method and corresponding tests #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamsi
reviewed
May 31, 2022
client_test.go
Outdated
| @@ -53,3 +53,9 @@ func TestSubmitPDF(t *testing.T) { | |||
| assert.NoError(t, err) | |||
| assert.NotNil(t, txRes) | |||
| } | |||
|
|
|||
| func TestBalance(t *testing.T) { | |||
| //t.Skip() | |||
There was a problem hiding this comment.
Just a note: #4 needs to be merged to enable tests.
liamsi
reviewed
May 31, 2022
client_test.go
Outdated
|
|
||
| func TestBalance(t *testing.T) { | ||
| //t.Skip() | ||
| _, err := NewClient("http://localhost:26658", WithTimeout(30*time.Second)) |
There was a problem hiding this comment.
Does the timeout really need to be that long?
There was a problem hiding this comment.
Probably not. I used 30 seconds value because of SubmitPFD tests (it waits for celestia block).
tzdybal
requested changes
May 31, 2022
client_test.go
Outdated
| @@ -53,3 +53,9 @@ func TestSubmitPDF(t *testing.T) { | |||
| assert.NoError(t, err) | |||
| assert.NotNil(t, txRes) | |||
| } | |||
|
|
|||
| func TestBalance(t *testing.T) { | |||
| //t.Skip() | |||
There was a problem hiding this comment.
Just a note: #4 needs to be merged to enable tests.
client_test.go
Outdated
|
|
||
| func TestBalance(t *testing.T) { | ||
| //t.Skip() | ||
| _, err := NewClient("http://localhost:26658", WithTimeout(30*time.Second)) |
There was a problem hiding this comment.
Probably not. I used 30 seconds value because of SubmitPFD tests (it waits for celestia block).
client.go
Outdated
| @@ -35,8 +35,23 @@ func (c *Client) Header(ctx context.Context, height uint64) /* Header */ error { | |||
| } | |||
|
|
|||
| func (c *Client) Balance(ctx context.Context) error { | |||
| _ = balanceEndpoint | |||
| return errors.New("method Balance not implemented") | |||
| var result balanceRequest | |||
There was a problem hiding this comment.
Suggested change
| var result balanceRequest | |
| var result balanceResponse |
|
@Regis-Caelum please rebase or merge with |
|
merged the changes with main |
tzdybal
requested review from
a team and
nashqueue
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Regis-Caelum [email protected]
Issues/PR
Fix Issue #8
Changes
structaccording to celestia documentation on balance response.Changes can be viewed in the files client.go, client_test.go, and type.go.