Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: type parametrized header #22

Merged
merged 3 commits into from
Aug 29, 2023
Merged

refactor!: type parametrized header #22

merged 3 commits into from
Aug 29, 2023

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Aug 27, 2023 •
edited
Loading

  • Bumps go-header doing necessary refactors to type system
  • Refactors away global fraud registry
    • I really tried to avoid this, but there was no way around it, as the registry must be type-parametrized with a Header.
    • I tried two other ways to solve this problem but wasted a lot of time.
    • Closes fraud: rework fraud proof registration. #9

@Wondertan Wondertan self-assigned this Aug 27, 2023
@celestia-bot celestia-bot requested review from gupadhyaya, nashqueue, a team and tzdybal and removed request for a team August 27, 2023 17:23
vgonkivs
vgonkivs previously approved these changes Aug 29, 2023
View reviewed changes
gupadhyaya
gupadhyaya previously approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@gupadhyaya gupadhyaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@renaynay renaynay dismissed stale reviews from gupadhyaya and vgonkivs via b34fa77 August 29, 2023 13:01
@renaynay renaynay merged commit b00ce70 into main Aug 29, 2023
7 checks passed
@renaynay renaynay deleted the type-paramed-header branch August 29, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@nashqueue nashqueue Awaiting requested review from nashqueue

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal was automatically assigned from celestiaorg/rollkit

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya

Assignees

@Wondertan Wondertan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fraud: rework fraud proof registration.
4 participants
@Wondertan @gupadhyaya @vgonkivs @renaynay