Feat: add subjective init opts #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
derrandz
force-pushed
the
feat/add-subjective-init-opts
branch
from
ee058ca to
2da10fd
Compare
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 66.22% 66.04% -0.18%
==========================================
Files 35 37 +2
Lines 2768 2848 +80
==========================================
+ Hits 1833 1881 +48
- Misses 785 808 +23
- Partials 150 159 +9
|
derrandz
force-pushed
the
feat/add-subjective-init-opts
branch
2 times, most recently
from
4cf22ca to
1917417
Compare
5 tasks
renaynay
reviewed
May 3, 2023
interface.go
Outdated
|
|
||
| type Option func(*HeadOptions) | ||
|
|
||
| type HeadOptions struct { |
There was a problem hiding this comment.
I'd call this RequestOptions because we can eventually extend other methods with opts too
p2p/exchange.go
Outdated
| @@ -38,7 +38,8 @@ type Exchange[H header.Header] struct { | |||
| trustedPeers func() peer.IDSlice | |||
| peerTracker *peerTracker | |||
|
|
|||
| Params ClientParameters | |||
| Params ClientParameters | |||
| headOpts header.HeadOptions | |||
p2p/exchange.go
Outdated
| log.Debug("requesting head") | ||
|
|
||
| for _, opt := range opts { | ||
| opt(&ex.headOpts) |
There was a problem hiding this comment.
load a default RequestOptions and range over it to apply opt
no need to store on exchange -- also every time there would be a request with opt, it would modify request options for the entire exchange and not just on a per call basis.
p2p/exchange.go
Outdated
Comment on lines
136
to
139
| for _, peer := range peers { | ||
| peerset = append(peerset, peer.ID) | ||
| } |
There was a problem hiding this comment.
just overwrite peerset with peers
There was a problem hiding this comment.
they are not of the same type and no need for refactors to make em so
p2p/exchange.go
Outdated
| if !ex.headOpts.SubjectiveInit { | ||
| // otherwise, node has a chain head that is NOT outdated so we can actually request random peers in | ||
| // addition to trusted | ||
| peers, err := ex.Params.peerstore.Load(ctx) |
There was a problem hiding this comment.
also remember that peerstore doesn't necessarily have to be set so you'd also have to ensure that peerstore is not nil
p2p/exchange.go
Outdated
Comment on lines
131
to
133
| if err != nil { // DISCUSS(team): should we return an error here or just use the trustedPeers? | ||
| var zero H | ||
| return zero, err |
derrandz
force-pushed
the
feat/add-subjective-init-opts
branch
from
cf34029 to
1c68702
Compare
derrandz
requested review from
tzdybal,
Wondertan,
vgonkivs and
gupadhyaya
as code owners
5 tasks
|
Superseded by other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows exchange to request head from non-trusted peers when the store is already initialized with a subjective head.
Part of the ADR 14 efforts
Depends on #36
Resolves #25
Checklist